ctype: exclude control bytes from ISPRINT and ISGRAPH - #22371
Closed
alhudz wants to merge 1 commit into
Closed
Conversation
bagder
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: with the bundled
fnmatch(a build without a systemfnmatch, such as Windows), match any byte in0x09-0x0d(\t \n \v \f \r) against[[:print:]]or[[:graph:]]; unit1307 gains those cases.Cause:
ISPRINTandISGRAPHfold in the0x09-0x0drange, so a byte there is reported as both printable andISCNTRL, unlike C/POSIX where the two are disjoint.Fix: drop that range from
ISPRINT/ISGRAPHso they agree withISCNTRL. The same misclassification let the LDAP-to-LDIF writer's!ISPRINTguard write a server value containingCR/LFraw into the line-oriented format instead of base64-encoding it.