md5: replace magic numbers with MD5_DIGEST_LEN - #22377
Closed
vszakats wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes repeated hard-coded 16 values for MD5 output length and replaces them with the shared MD5_DIGEST_LEN constant, improving consistency and reducing the chance of mismatched digest-size assumptions across different crypto backends.
Changes:
- Replace
16withMD5_DIGEST_LENin multiple MD5 backend implementations (nettle, PSA Crypto, Win32 CryptoAPI). - Use
MD5_DIGEST_LENfor the declared result sizes inCurl_HMAC_MD5andCurl_DIGEST_MD5parameter tables.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There may be more of these, also for MD4 and possibly others.