runtests: fix mode="warn" tests passing unconditionally, fix test 1752 - #22388
Closed
vszakats wants to merge 8 commits into
Closed
runtests: fix mode="warn" tests passing unconditionally, fix test 1752#22388vszakats wants to merge 8 commits into
mode="warn" tests passing unconditionally, fix test 1752#22388vszakats wants to merge 8 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes how tests/runtests.pl concatenates expected/actual stderr when mode="warn" is used, ensuring warnings are normalized and compared reliably during test verification.
Changes:
- Corrects Perl
joinargument order so concatenation uses an empty separator (join("", @list)), rather than unintentionally using the first element as the separator. - Ensures
mode="warn"normalization produces consistent single-stringstderrcontent for subsequent comparison.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vszakats
changed the title
mode="warn" passing unconditionallymode="warn" Perl code
vszakats
changed the title
mode="warn" Perl codemode="warn" tests passing unconditionally
vszakats
changed the title
mode="warn" tests passing unconditionallymode="warn" tests passing unconditionally
vszakats
marked this pull request as ready for review
July 25, 2026 14:36
vszakats
changed the title
mode="warn" tests passing unconditionallymode="warn" tests passing unconditionally, fix test 1752
https://github.com/curl/curl/actions/runs/30157378719/job/89677347334?pr=22388 ``` 1712: stderr FAILED: --- log/15/check-expected 2026-07-25 12:06:56.801503774 +0000 +++ log/15/check-generated 2026-07-25 12:06:56.801472576 +0000 @@ -1,2 +1,2 @@ -log/15/config:1 Option 'data' uses argument with leading single quote. -It is probably a mistake. Consider double quotes. +log/15/config:1 Option 'data' uses argument with leading single +quote. It is probably a mistake. Consider double quotes. ``` https://github.com/curl/curl/actions/runs/30157378719/job/89677347334?pr=22388
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix test 1712 to pass curl C by setting
COLUMNSto the highestaccepted value, and adjust expected results. To avoid envs with varying
lengths of
LOGDIRaffect the outcome.Apply the same fix to test 459, though it wasn't affected in curl CI.
Also sync up test 433
COLUMNSvalue with these two tests forconsistency.
Ref: #22381
Follow-up to 8e3a2a6 #20666