runtests: allow comments in setenv section, merge sections in test433 - #22389
Closed
vszakats wants to merge 1 commit into
Closed
runtests: allow comments in setenv section, merge sections in test433#22389vszakats wants to merge 1 commit into
setenv section, merge sections in test433#22389vszakats wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the curl test runner to support comment lines inside <setenv> sections in test definitions, and simplifies test433 by consolidating its environment setup into a single <setenv> block.
Changes:
- Teach
tests/runner.pmto ignore#...comment lines when processing<setenv>. - Merge the duplicated
<setenv>sections intests/data/test433and keep the explanatory note as an inline comment. - Keep the
COLUMNS=300adjustment within the main env block to avoid word-wrapped output during the test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/runner.pm | Skips # comment lines while parsing <setenv> entries so comments don’t get treated as environment variable names. |
| tests/data/test433 | Consolidates env setup into one <setenv> section and adds an inline comment for the COLUMNS override. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
It appears we have an upstream CI meltdown. |
setenv section, merge sections in test433
bagder
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments were silently allowed before this patch, but internally they
were handled as env deletion commands, which just failed or did not
do harm. I figure it's better to allow explicitly and not pass to OS.