Skip to content

vquic: initialize new callback slot for nghttp3 v1.18.0+ - #22399

Closed
vszakats wants to merge 2 commits into
curl:masterfrom
vszakats:nghttp3maint
Closed

vquic: initialize new callback slot for nghttp3 v1.18.0+#22399
vszakats wants to merge 2 commits into
curl:masterfrom
vszakats:nghttp3maint

Conversation

@vszakats

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings July 26, 2026 14:28
@github-actions github-actions Bot added the HTTP/3 h3 or quic related label Jul 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds compatibility for nghttp3 v1.18.0+ by explicitly initializing the newly introduced callback slot in curl’s ngtcp2 HTTP/3 callbacks table.

Changes:

  • Extend nghttp3_callbacks initializer to include the stream_close2 callback (set to NULL) when NGHTTP3_CALLBACKS_V4 is available (nghttp3 v1.18.0+).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/vquic/cf-ngtcp2.c
Copilot AI review requested due to automatic review settings July 26, 2026 14:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@vszakats vszakats closed this in e416e29 Jul 26, 2026
@vszakats
vszakats deleted the nghttp3maint branch July 26, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HTTP/3 h3 or quic related

Development

Successfully merging this pull request may close these issues.

2 participants