cf-ngtcp2-cmn: de-duplicate ngtcp2_conn_client_new() call code - #22401
Closed
vszakats wants to merge 1 commit into
Closed
cf-ngtcp2-cmn: de-duplicate ngtcp2_conn_client_new() call code#22401vszakats wants to merge 1 commit into
ngtcp2_conn_client_new() call code#22401vszakats wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors QUIC connection setup in cf_connect_start() to remove duplicated ngtcp2_conn_client_new() and ctx->conn_ref initialization logic, keeping the direct-socket and tunneled-socket address setup as the only conditional parts.
Changes:
- Moved
ngtcp2_conn_client_new()to run once after the direct/tunneled address initialization branches. - Moved
ctx->conn_refinitialization to a single shared location after successful connection creation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/curl/curl/pull/22401/files?w=1