Skip to content

typecheck-gcc: allow passing char[] as callback data - #22409

Closed
vszakats wants to merge 2 commits into
curl:masterfrom
vszakats:typecheck-cb-data-chararr
Closed

typecheck-gcc: allow passing char[] as callback data#22409
vszakats wants to merge 2 commits into
curl:masterfrom
vszakats:typecheck-cb-data-chararr

Conversation

@vszakats

@vszakats vszakats commented Jul 27, 2026

Copy link
Copy Markdown
Member

E.g. TEST_DATA_STRING in test 655.

Cherry-picked from #22406

Copilot AI review requested due to automatic review settings July 27, 2026 14:29
@vszakats
vszakats force-pushed the typecheck-cb-data-chararr branch from c2762af to ce1cab6 Compare July 27, 2026 14:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates curl’s GCC/clang typechecking helper macros so char[] arrays are accepted as “pointer-like” callback/userdata values when using the curl_easy_setopt() typechecker.

Changes:

  • Extend curlcheck_any_ptr() to also treat char[] expressions as valid, in addition to pointer-sized expressions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread include/curl/typecheck-gcc.h Outdated
Copilot AI review requested due to automatic review settings July 27, 2026 14:33
@vszakats vszakats changed the title typecheck-gcc: allow passing char[] as callback data typecheck-gcc: allow passing char [] as callback data Jul 27, 2026
@vszakats vszakats changed the title typecheck-gcc: allow passing char [] as callback data typecheck-gcc: allow passing char[] as callback data Jul 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings July 27, 2026 14:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread include/curl/typecheck-gcc.h
@vszakats vszakats closed this in c5ad90b Jul 27, 2026
@vszakats
vszakats deleted the typecheck-cb-data-chararr branch July 27, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants