lib2405: adjust for non-threaded builds

[bagder]

• Attempt to fix the flakiness set in 9726fc8
• Reduce macro use

[bagder]

Lesson: stop linking to CI logs in commit messages, because they are likely gone by the time we want to follow those links...

[Copilot]

Pull request overview

This PR updates the lib2405/lib2407 test logic to make curl_multi_waitfds() expectations depend on whether the build uses an async/threaded resolver, with the goal of eliminating prior flakiness and reducing preprocessor macro usage. It also removes the flaky keyword from the corresponding test definitions.

Changes:

• Replace macro-based “run + check” helpers in lib2405.c with a real helper function and compute expected waitfd counts based on resolver mode.
• Add a resolver-mode detection helper using curl_version_info() feature metadata.
• Remove the flaky keyword from tests/data/test2405 and tests/data/test2407.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
tests/libtest/lib2405.c	Refactors checks into functions and adjusts expected waitfd counts based on resolver mode.
tests/data/test2405	Removes flaky keyword for the test.
tests/data/test2407	Removes flaky keyword for the test.

Comments suppressed due to low confidence (1)

tests/libtest/lib2405.c:396

• This comment says "+ wakeup" unconditionally, but the expected fd count is now conditional on uses_threaded_resolver. Update the comment to match the new expectation.

    /* HTTP2, one for each transfer + wakeup */

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[testclutch]

Analysis of PR #22414 at 848a6830:

Test 710 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 4 different CI jobs (the link just goes to one of them).

Generated by Testclutch