scorecard: fix max_upload init value in ul_parallel() - #22421
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
"In `ul_parallel`, `max_parallel` is computed using `self._download_parallel` instead of `self._upload_parallel`. This causes the upload parallelism to incorrectly follow the download parallel setting. It should use `self._upload_parallel` to be consistent with how `uploads()` computes `max_parallel`." Reported by GitHub Code Quality Follow-up to 30ef79e curl#17295
There was a problem hiding this comment.
Pull request overview
This PR fixes upload parallelism selection in the HTTP scorecard runner so that upload runs respect the upload-parallel configuration rather than incorrectly following the download-parallel setting.
Changes:
- Correct
ul_parallel()to computemax_parallelfromself._upload_parallel(matchinguploads()behavior).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vszakats
changed the title
max_upload value in ul_parallel()max_upload init value in ul_parallel()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"In
ul_parallel,max_parallelis computed usingself._download_parallelinstead ofself._upload_parallel. Thiscauses the upload parallelism to incorrectly follow the download
parallel setting. It should use
self._upload_parallelto be consistentwith how
uploads()computesmax_parallel."Reported by GitHub Code Quality
Follow-up to 30ef79e #17295