sws: log the exact closing reason better, to help debugging tests - #22431
Closed
bagder wants to merge 1 commit into
Closed
sws: log the exact closing reason better, to help debugging tests#22431bagder wants to merge 1 commit into
bagder wants to merge 1 commit into
Conversation
bagder
changed the title
There was a problem hiding this comment.
🟢 Ready to approve
The change is a low-risk logging-only refinement in test server code and preserves the existing close behavior while adding clearer diagnostics.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR refines how the sws test server reports why it is closing a connection, improving the usefulness of test logs when diagnosing failures.
Changes:
- Splits a combined “close connection” condition into distinct branches.
- Adds more specific
logmsg()messages for each close reason (response marker, empty response, or<servercmd>close).
File summaries
| File | Description |
|---|---|
| tests/server/sws.c | Improves connection-close logging by distinguishing the specific trigger that caused persistent = FALSE. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.