tests: convert unit tests into libtests - #22471
Closed
bagder wants to merge 2 commits into
Closed
Conversation
It was previously a unit test but it uses only public library functions
It uses only public libcurl functions
bagder
changed the title
There was a problem hiding this comment.
Pull request overview
This PR moves two tests (1396 and 1398) from the unit-test harness into the libtest harness, aligning with the stated intent that they only exercise public libcurl APIs.
Changes:
- Remove
unit1396/unit1398from the unit-test build list and addlib1396/lib1398to the libtest build list. - Rename the test entry functions from
test_unit####totest_lib####in the corresponding libtest sources. - Update
test1396andtest1398definitions to run via<tool>lib%TESTNUMBER</tool>instead of marking them asunittest.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/Makefile.inc | Drops 1396/1398 from the unit test compilation set. |
| tests/libtest/Makefile.inc | Adds 1396/1398 to the libtest compilation set. |
| tests/libtest/lib1396.c | Renames the libtest entry function to the libtest naming convention. |
| tests/libtest/lib1398.c | Renames the libtest entry function to the libtest naming convention. |
| tests/data/test1396 | Switches the test runner from unit-test mode to lib%TESTNUMBER. |
| tests/data/test1398 | Switches the test runner from unit-test mode to lib%TESTNUMBER. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These use only public libcurl functions and should therefore be libtests