http2: make server push transfers inherit share from parent - #22488
Closed
bagder wants to merge 2 commits into
Closed
http2: make server push transfers inherit share from parent#22488bagder wants to merge 2 commits into
bagder wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure HTTP/2 server-push transfers created via handle duplication inherit the parent transfer’s share object, so pushed transfers participate in the same shared state (e.g., cookies/HSTS/PSL/DNS caches) as the initiating request.
Changes:
- In
lib/http2.c, assign the parentshareto the duplicated easy handle and increment the share refcount. - In
lib/curl_share.c/lib/curl_share.h, make the share refcount increment helper (Curl_share_ref_inc) non-static and callable from other translation units.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/http2.c | Adds share inheritance logic for duplicated handles used by HTTP/2 server push. |
| lib/curl_share.h | Exposes Curl_share_ref_inc() declaration for cross-file use. |
| lib/curl_share.c | Renames and exports the refcount increment function and updates its call site. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bagder
force-pushed
the
bagder/h2-push-share
branch
from
August 5, 2026 09:01
a80e320 to
30cfd20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.