Conversation
Suggested-by: Marcel Jamin URL: https://curl.se/mail/lib-2026-08/0002.html Closes #22494
bagder
force-pushed
the
bagder/win-no-syn-retrans
branch
from
August 5, 2026 13:31
d88364c to
0986092
Compare
bagder
marked this pull request as ready for review
August 5, 2026 13:33
There was a problem hiding this comment.
Pull request overview
This PR adjusts Windows socket behavior for localhost connections by disabling TCP SYN retransmissions, aiming to fail faster when localhost targets are unreachable.
Changes:
- Include Windows TCP RTO definitions via
mstcpip.hand add a Windows-onlyWSAIoctl(SIO_TCP_INITIAL_RTO)call for localhost targets. - Add a
typosconfiguration exception forrto/RTOidentifiers used by the new code.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/cf-socket.c | Adds Windows-only logic to disable SYN retransmissions for localhost connects via SIO_TCP_INITIAL_RTO. |
| .github/scripts/typos.toml | Adds rto/RTO to typos ignore list to avoid false positives. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vszakats
reviewed
Aug 5, 2026
vszakats
reviewed
Aug 5, 2026
Viktor's proposals Co-authored-by: Viktor Szakats <vszakats@users.noreply.github.com>
Member
Author
|
Marcel Jamin confirmed privately to me that this PR seems to make failed connect attempts to local host fail much faster. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested-by: Marcel Jamin
URL: https://curl.se/mail/lib-2026-08/0002.html