Conversation
They were the same anyway!
The code did bitwise ANDs in the conditions but the values are not bits, they are identifiers so these checks never worked.
It never worked, and when fixed we have test cases that break...
There was a problem hiding this comment.
Pull request overview
This pull request refactors internal RTSP request-method handling to use the public CURL_RTSPREQ_* values directly, simplifying method selection and consolidating header construction/error handling in the RTSP implementation.
Changes:
- Replace the internal
Curl_RtspReqenum with anunsigned charrequest selector stored ondata->set. - Refactor RTSP method selection into a table-driven helper (
pick_method) and centralize header allocation (rtsp_header_alloc). - Tighten
CURLOPT_RTSP_REQUESTvalidation to a simple range check and include RTSP request constants vialib/rtsp.h.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/urldata.h | Removes internal RTSP request enum and stores request type as unsigned char in UserDefined. |
| lib/transfer.c | Includes rtsp.h to access RTSP request constants in transfer-layer logic. |
| lib/setopt.c | Simplifies RTSP request option parsing/validation and stores the request value directly. |
| lib/rtsp.h | Adds internal RTSPREQ_* aliases mapping to public CURL_RTSPREQ_* constants. |
| lib/rtsp.c | Refactors RTSP request creation into smaller helpers and table-driven method handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.