header api: add guards - #22530
Closed
icing wants to merge 4 commits into
Closed
header api: add guards#22530icing wants to merge 4 commits into
icing wants to merge 4 commits into
Conversation
icing
force-pushed
the
header-api-guards
branch
from
August 10, 2026 11:55
2597281 to
e547acd
Compare
bagder
approved these changes
Aug 10, 2026
There was a problem hiding this comment.
Pull request overview
Adds easy API guards to the HTTP header access APIs and removes obsolete header state.
Changes:
- Guards header lookup and iteration calls.
- Converts guard failures to
CURLHcode. - Removes unused
prevheadstate.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lib/api.c |
Registers header APIs and converts guard errors. |
lib/api.h |
Declares guard identifiers and conversion helper. |
lib/headers.c |
Applies guards and removes obsolete assignments. |
lib/urldata.h |
Removes the unused prevhead member. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Add API guards for curl_easy_header and curl_easy_nextheader. urldata.h: remove prevhead member as not used
icing
force-pushed
the
header-api-guards
branch
from
August 11, 2026 07:52
e547acd to
ae4d0e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add API guards for curl_easy_header and curl_easy_nextheader.
urldata.h: remove prevhead member as not used