schannel: reuse the send buffer - #22540
Closed
hunterinvariants wants to merge 1 commit into
Closed
hunterinvariants wants to merge 1 commit into
hunterinvariants wants to merge 1 commit into
Conversation
Contributor
Author
|
One CI job was cancelled at the 15-minute limit: Could someone with workflow permissions rerun the cancelled job? |
jay
approved these changes
Aug 11, 2026
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse a connection-local buffer for encrypted Schannel writes instead of allocating and freeing a buffer for every send. Grow it when needed and release it when the connection is closed.
In a native Windows debug build, 30 sequential HTTPS transfers over one reused connection changed the send-buffer heap activity from 30 allocations and 30 frees to one allocation and one close-time free.
Verified with checksrc, MinGW 32-bit and 64-bit Schannel builds, and native Windows 11 Schannel runs.