Conversation
To match CMake-generated ones and to keep it tidy.
There was a problem hiding this comment.
Pull request overview
Normalizes spacing in Autotools-generated libcurl.pc files to align with CMake output.
Changes:
- Strips duplicate spaces following colons.
- Updates the cleanup comment accordingly.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vszakats
changed the title
libcurl.pclibcurl.pc
vszakats
force-pushed
the
am-strip-dupe-space-aft-colon
branch
from
August 11, 2026 09:32
d84ca6a to
2ec9fa2
Compare
vszakats
changed the title
libcurl.pcLibs.private: in libcurl.pc
vszakats
added a commit
that referenced
this pull request
Aug 12, 2026
To keep it tidy and to support properties in the template that only appear in the generated `libcurl.pc` when filled. E.g. `Required.private` may remain empty after #22548. Also: - GHA/windows: dump `libcurl.pc` to log in every job - tidy up a pre-existing regex in the updated command. 2c22d30 #22544 Ref: b9254da #22548 Cherry-picked from #22543 Closes #22553
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
LIBCURL_PC_LDFLAGS_PRIVATEis empty andLIBCURL_PC_LIBS_PRIVATEis not.
To keep it tidy.