Conversation
icing
force-pushed
the
easy-progress-improve
branch
from
August 11, 2026 15:10
2fb7cc9 to
e46a2dc
Compare
icing
force-pushed
the
easy-progress-improve
branch
from
August 12, 2026 08:51
e46a2dc to
b48ba67
Compare
There was a problem hiding this comment.
Pull request overview
Refactors progress timing to reduce easy-handle memory usage using one start timestamp and microsecond offsets.
Changes:
- Separates timing offsets and accumulated durations.
- Migrates timeout, progress, and getinfo calculations.
- Updates related unit tests and removes the unused FTP accept timer.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
lib/progress.c |
Implements offset-based timing and speed tracking. |
lib/progress.h |
Updates progress timing APIs and timer IDs. |
lib/urldata.h |
Reorganizes progress timing storage. |
lib/getinfo.c |
Reads timing values from the new structures. |
lib/connect.c |
Uses offset-based timeout calculations. |
lib/multi.c |
Updates elapsed timeout reporting. |
lib/transfer.c |
Migrates progress initialization and timeout reporting. |
lib/tftp.c |
Migrates TFTP progress initialization. |
lib/ftp.c |
Removes unused accept timing. |
lib/cf-ip-happy.c |
Migrates connection elapsed-time reporting. |
lib/vdns/cf-dns.c |
Migrates DNS timeout reporting. |
tests/unit/unit1303.c |
Adapts timeout tests to offset timing. |
tests/unit/unit1399.c |
Adapts cumulative timing tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Keep only a single `start` time and calculate the rest in delta microseconds since then. Separate timestamps and durations into separate sub-structures for clarity. remove progress.t_acceptdata It was recorded in FTP accept but never used anywhere.
icing
force-pushed
the
easy-progress-improve
branch
from
August 12, 2026 12:27
b48ba67 to
c7f5ec7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep only a single
starttime and calculate the rest in delta microseconds since then. Separate timestamps and durations into separate sub-structures for clarity.Shaves some more bytes off the easy handle.