Conversation
vszakats
marked this pull request as draft
August 11, 2026 14:32
vszakats
changed the title
Require.private for full-static builds in libcurl.pcRequire.private for static-only builds in libcurl.pc
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Pull request overview
Prevents duplicate dependency modules in static-only libcurl.pc files.
Changes:
- Clears
Requires.privateafter promoting dependencies toRequires. - Applies the fix consistently to Autotools and CMake builds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
configure.ac |
Clears private requirements for static-only Autotools builds. |
CMakeLists.txt |
Mirrors the behavior for CMake builds. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vszakats
marked this pull request as ready for review
August 12, 2026 08:45
2 tasks
vszakats
added a commit
that referenced
this pull request
Aug 12, 2026
To keep it tidy and to support properties in the template that only appear in the generated `libcurl.pc` when filled. E.g. `Required.private` may remain empty after #22548. Also: - GHA/windows: dump `libcurl.pc` to log in every job - tidy up a pre-existing regex in the updated command. 2c22d30 #22544 Ref: b9254da #22548 Cherry-picked from #22543 Closes #22553
vszakats
added a commit
that referenced
this pull request
Aug 12, 2026
…pccritic` tool `pccritic` is available on the latest macOS runner revision (not every job runs get it yet), Cygwin, MSYS2/mingw-w64 (one job, others will follow on the next msys2/setup-msys2 Action bump). It will be automatically used on BSDs, once they start offering it. Missing from Linux jobs. Also: - GHA/windows: convert `libcurl.pc` to Unix newlines to bump score 96 to 100 in mingw-w64 jobs. CMake-specific fix pending in: #22556 - GHA: verify with minimum `pccritic` score 94 to 100 (depending on CI job). - build: fill `Maintainer:` `libcurl.pc` property when run curl CI. Issues remaining: macOS: ``` [info ] Cflags adds an include path already on the default search path (pkgconf strips it): -I/usr/local/include (cflags/PC031) [info ] Libs adds a library path already on the default search path (pkgconf strips it): -L/usr/local/lib (libs/PC040) [minor ] Libs.private contains an unexpected flag: /Applications/Xcode_26.6.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX26.5.sdk/System/Library/Frameworks/GSS.framework (libs/PC041) ``` Windows: ``` [minor ] file uses CRLF line endings (style/PC061) ``` Ref: #22556 Follow-up to b9254da #22548 Follow-up to 852f5d3 #22553 Follow-up to 4d9ba9f #22545 Follow-up to 6c7993d #22536 Follow-up to 3f1c033 #22519 Closes #22543
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch static-only libcurl builds stored the list of module
dependencies in both
RequireandRequire.private. The newpccritictool flagged this as an issue. Having (or not) a duplicate in
Require.privatedoes not change the output created bypkgconfandpkg-config, as tested with both with and without--staticoption.Thus, fix by deleting the private copy.
Fixing:
Ref: https://github.com/curl/curl/actions/runs/31495008715/job/93790403026#step:10:210 (macOS, CM clang OpenSSL torture)
Ref: https://github.com/curl/curl/actions/runs/31495008825/job/93790433646#step:9:216 (mingw, AM ucrt-x86_64 wolfssl c-ares U)
Follow-up to f057de5 #13911
Follow-up to 98e5904 #5373
Cherry-picked from #22543