Conversation
It can never be true elsewhere. Reported-by: Max Dymond
There was a problem hiding this comment.
Pull request overview
This PR avoids performing a runtime TLS-backend probe for Schannel on non-Windows platforms by compiling a trivial is_using_schannel() stub when _WIN32 is not defined, since Schannel cannot be selected there.
Changes:
- Wrap
is_using_schannel()in#ifdef _WIN32and provide a non-Windows implementation that always returns “not using Schannel”. - Preserve existing behavior on Windows (including cached detection via
curl_easy_getinfo(..., CURLINFO_TLS_SSL_PTR, ...)).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can never be true elsewhere.
Reported-by: Max Dymond