Conversation
The only usage of the thread queue and pool is for "DNS" which is a static string. No point in strdup'ing it (twice). Future users are *likely* to also used fixed strings, otherwise we revert this change when dynamic names are introduced. Reported-by: Max Dymond
There was a problem hiding this comment.
Pull request overview
This PR removes duplicated allocations of thread queue/pool name strings by treating them as long-lived constants, reducing unnecessary strdup/free overhead in the threaded DNS resolver’s queue/pool setup.
Changes:
- Store
nameinstruct curl_thrdqasconst char *and stop duplicating/freeing it. - Store
nameinstruct curl_thrdpoolasconst char *and stop duplicating/freeing it.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/thrdqueue.c | Switch queue name storage to non-owning const char * and remove cleanup/free of the duplicated name. |
| lib/thrdpool.c | Switch pool name storage to non-owning const char * and remove cleanup/free of the duplicated name. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
icing
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only usage of the thread queue and pool is for "DNS" which is a static string. No point in strdup'ing it (twice). Future users are likely to also use fixed strings, otherwise we revert this change when dynamic names are introduced.
Reported-by: Max Dymond