Conversation
The dedotdotify() function that removes ./ and ../ sequences from paths juggles memory and is slow. Now needs_dedotdot() is called first to determine if the removal process is necessary and otherwise avoids doing it. Avoids unnecessary memory operations. Adjusted unit test 1395 accordingly because now a lot of input strings return NULL for "no change necessary". Suggested-by: Max Dymond
There was a problem hiding this comment.
Pull request overview
This PR optimizes URL path dot-segment cleanup in lib/urlapi.c by adding a fast prescan to skip dedotdotify() when no rewrite is needed, and updates unit test expectations accordingly (many “no change” inputs now yield NULL output).
Changes:
- Add
needs_dedotdot()prescan and early-return fromdedotdotify()to avoid unnecessary work/allocation. - Update unit test 1395 expected outputs to reflect the new “no change => NULL output” behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/urlapi.c | Adds prescan logic to avoid running dedotdotify() when unnecessary. |
| tests/unit/unit1395.c | Updates expected results to match new dedotdotify() output behavior (more NULLs). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bagder
marked this pull request as ready for review
August 12, 2026 10:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dedotdotify() function that removes ./ and ../ sequences from paths juggles memory and is slow. Now needs_dedotdot() is called first to determine if the removal process is necessary and otherwise avoids doing it. Avoids unnecessary memory operations.
Adjusted unit test 1395 accordingly because now a lot of input strings return NULL for "no change necessary".
Suggested-by: Max Dymond