Conversation
Since this code needs to work (identically) on systems with 32 bit longs anyway, this might just as well always use 32 bit to save space and make the code work the same everywhere.
There was a problem hiding this comment.
Pull request overview
Uses int for internal multi-handle timeout values, ensuring consistent 32-bit behavior across platforms.
Changes:
- Converts internal timeout storage and calculations from
longtoint. - Clamps oversized timeout differences to
INT_MAX. - Updates tracing format specifiers and public API conversion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/multihandle.h |
Stores the last callback timeout as an int. |
lib/multi.c |
Converts, clamps, and reports internal timeouts as int. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this code needs to work (identically) on systems with 32 bit longs anyway, this might just as well always use 32 bit to save space and make the code work the same everywhere.