Conversation
Follow-up to 855acb3 curl#17701 Follow-up to f58342a curl#15562 Follow-up to cd51bb5 curl#14439
There was a problem hiding this comment.
Pull request overview
Uses CMake 4.5’s built-in diagnostic functions while retaining compatibility fallbacks.
Changes:
- Adopt built-in variable and target-property dumping.
- Align fallback formatting and property ordering with CMake output.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
CMake/Utilities.cmake:73
- Sorting before expanding
<CONFIG>still does not match CMake's alphabetical output. For example,<CONFIG>_POSTFIXsorts at the start, then expands toDEBUG_POSTFIX; curl initializes that property, and the explicitDEBUG_POSTFIXentry causes it to be printed again later. Expand and de-duplicate the concrete property names before sorting them.
list(SORT _cmake_property_list)
Member
Author
Sorting (and being like CMake) is not important to justify any complexity here. This is OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Their output is nearly identical to curl's implementations. Minor
differences: it goes to stdout (curl: stderr), marks cache variables,
but doesn't mark 'advanced' ones.
Also:
Refs:
https://gitlab.kitware.com/cmake/cmake/-/commit/f723293c7f625b14bd48627042fc04e67b76c513
https://gitlab.kitware.com/cmake/cmake/-/merge_requests/11834
https://gitlab.kitware.com/cmake/cmake/-/work_items/27513
https://cmake.org/cmake/help/git-master/command/cmake_language.html#command:cmake_language
Follow-up to 855acb3 #17701
Follow-up to f58342a #15562
Follow-up to cd51bb5 #14439
I wish there was also a function to retrieve command-line arguments.
The current hack e.g. doesn't work as expected when vcpkg is used.
https://github.com/curl/curl/pull/22566/files?w=1
Tested OK with cmake-4.4.20260811-g567ed0e.