Skip to content

tool_operate: limit is_using_schannel() call to Windows - #22568

Closed
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:issch
Closed

vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:issch

Conversation

@vszakats

Copy link
Copy Markdown
Member

Follow-up to cd238bb #22552

@vszakats vszakats added Windows Windows-specific tidy-up labels Aug 13, 2026
@vszakats vszakats changed the title tool_operate: omit is_using_schannel() call on non-Windows tool_operate: limit is_using_schannel() call to Windows Aug 13, 2026
@vszakats vszakats added the TLS label Aug 13, 2026
@vszakats vszakats closed this in 9d03453 Aug 13, 2026
@vszakats
vszakats deleted the issch branch August 13, 2026 09:23
@bagder

bagder commented Aug 13, 2026

Copy link
Copy Markdown
Member

I did it my way to avoid exactly this: introducing more #ifdefs in the flow...

@vszakats

vszakats commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

I did it my way to avoid exactly this: introducing more #ifdefs in the flow...

It's more explicit, and also shorter this way and avoids a runtime call
on non-Windows. IMO simplifies code, even with the two guards.

I agree to reduce _WIN32 where possible, but for inevitable
Windows-specific code, it seems fine to use and make these parts
easy to spot, I think.

@bagder

bagder commented Aug 13, 2026

Copy link
Copy Markdown
Member

I have another polish PR coming... =)

@icing

icing commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

The curl PR wars started late summer 2026...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants