Conversation
There was a problem hiding this comment.
Pull request overview
Caps internal multi-handle expiration times at INT_MAX.
Changes:
- Adds timeout capping in
Curl_expire_ex(). - Documents the signed 32-bit limit.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bagder
force-pushed
the
bagder/cap-expire
branch
from
August 14, 2026 08:02
1902fb5 to
fa7f38e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the time-out value is passed to the outside world it needs to fit in a signed 32-bit variable (on Windows and 32-bit architectures) anyway. Also, this is 3.5 weeks and we should not knowingly set timeouts that long anyway.
The previous cap introduced in 3089e7e was only partial.