openssl: fix pinned public key build error in FIPS mode #2258

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant
@bagder
Member

bagder commented Jan 23, 2018

Here is a version that should work with all versions of openssl 0.9.7
through 1.1.0.

Links to the docs:
https://www.openssl.org/docs/man1.0.2/crypto/EVP_DigestInit.html
https://www.openssl.org/docs/man1.1.0/crypto/EVP_DigestInit.html

At the very bottom of the 1.1.0 documentation there is a history section
that states, " stack allocated EVP_MD_CTXs are no longer supported."

If EVP_MD_CTX_create and EVP_MD_CTX_destroy are not defined, then a
simple mapping can be used as described here:
https://wiki.openssl.org/index.php/Talk:OpenSSL_1.1.0_Changes

openssl: fix pinned public key build error in FIPS mode
Here is a version that should work with all versions of openssl 0.9.7
through 1.1.0.

Links to the docs:
https://www.openssl.org/docs/man1.0.2/crypto/EVP_DigestInit.html
https://www.openssl.org/docs/man1.1.0/crypto/EVP_DigestInit.html

At the very bottom of the 1.1.0 documentation there is a history section
that states, " stack allocated EVP_MD_CTXs are no longer supported."

If EVP_MD_CTX_create and EVP_MD_CTX_destroy are not defined, then a
simple mapping can be used as described here:
https://wiki.openssl.org/index.php/Talk:OpenSSL_1.1.0_Changes

@bagder bagder added the SSL/TLS label Jan 23, 2018

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Jan 23, 2018

Member

Apple builds not working (as usual), the rest looks fine. I'm still holding off merging this until after 7.58.0 ships tomorrow to not rock the boat the last minute.

Member

bagder commented Jan 23, 2018

Apple builds not working (as usual), the rest looks fine. I'm still holding off merging this until after 7.58.0 ships tomorrow to not rock the boat the last minute.

@jay jay referenced this pull request in travis-ci/travis-ci Jan 23, 2018

Closed

The travis job is stalled. #9102

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Jan 24, 2018

Member

ping @moparisthebest, but I take it you have no objection as long as this works?

Member

bagder commented Jan 24, 2018

ping @moparisthebest, but I take it you have no objection as long as this works?

@bagder bagder closed this in 1433e46 Jan 25, 2018

@bagder bagder deleted the bagder/pinnedpubkey-fips branch Jan 25, 2018

@curl curl locked as resolved and limited conversation to collaborators May 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.