Conversation
- 'upgr101' from enum upgrade101 => 'unsigned char', saves three bytes - made some 'unsigned char' => uint8_t - moved 'io_flags' to fill a hole on 64-bit arch Takes it down from 248 to 232 bytes with no functional change.
Sort the fields by size. Larger to smaller. Helps avoding holes. - httpsig_algorithm moved - FTP uint8_t fields moved - new_file_perms moved - rtspreq moved 1856 => 1832 bytes with no functional change.
It only had a single struct member 'weight'. Use that directly instead to save indirections and struct alignments. Move field for size order.
To be ordered by size
- make 'pxcode' a uint8_t - move 'conn_protocol' to fill a hole
There was a problem hiding this comment.
Pull request overview
Optimizes internal data structures to reduce padding and memory usage without changing behavior.
Changes:
- Reorders fields by size and narrows suitable enum storage.
- Flattens HTTP/2 priority weight structures.
- Updates all affected initialization and access sites.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
lib/urldata.h |
Reorganizes internal structure layouts. |
lib/url.c |
Updates priority initialization and reset. |
lib/socks.c |
Stores proxy errors in narrowed storage. |
lib/setopt.c |
Updates stream-weight assignment. |
lib/request.h |
Compacts request state fields. |
lib/http2.c |
Uses flattened priority weight fields. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key is to sort struct fields by size...