Conversation
vszakats
marked this pull request as draft
August 15, 2026 07:14
vszakats
changed the title
opendir() detection on Windowsdirent.h and opendir() detections on Windows
There was a problem hiding this comment.
Pull request overview
Removes obsolete Windows checks for dirent.h and opendir() following the native Win32 directory-listing implementation.
Changes:
- Restricts Autoconf checks to non-native Windows targets.
- Restricts CMake checks to non-Windows targets.
- Removes obsolete Windows cache entries.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
configure.ac |
Skips obsolete checks on native Windows. |
CMakeLists.txt |
Moves checks into the non-Windows block. |
CMake/win32-cache.cmake |
Removes cached Windows feature values. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opendir()was used previously with mingw-w64 forfile://directorylisting support. This was replaced by a native Win32 solution on all
Windows platforms, leaving
opendir()no longer used. Drop relatedfeature detections.
Follow-up to c7c42af #22577
Note,
config-win32.hdid not prefill this for mingw-w64. This is moreof a missed "formality" or documentation, because this header hasn't
been used with mingw-w64 for a good while now, at least not from within
curl.