Conversation
There was a problem hiding this comment.
Pull request overview
Limits gettimeofday() detection to non-Windows targets, aligning MinGW and MSVC builds.
Changes:
- Removes Windows-specific feature definitions.
- Restricts Autoconf and CMake detection to non-Windows platforms.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
lib/config-win32.h |
Removes the MinGW definition. |
configure.ac |
Moves detection into the non-Windows block. |
CMakeLists.txt |
Restricts detection to non-Windows targets. |
CMake/win32-cache.cmake |
Removes cached Windows defaults. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vszakats
force-pushed
the
w-drop-gettimeofday
branch
from
August 16, 2026 08:11
36bcf01 to
410d142
Compare
To remove a build difference between mingw-w64 and MSVC builds, simplify and save the cost of detection/verification in CI. `gettimeofday()` was used in `curl_threads.c` in codepath practically unreachable in Windows builds, and in `tool_writeout.c` that was a fallback to `time()` for targets without it. Ref: curl#22593
vszakats
force-pushed
the
w-drop-gettimeofday
branch
from
August 16, 2026 10:22
410d142 to
1bf852e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To remove a build difference between mingw-w64 and MSVC builds (where
mingw-w64 has it, while MSVC does not). Also to simplify and save the
cost of detection/verification in CI.
gettimeofday()was used incurl_threads.cin codepath practicallyunreachable in Windows builds, and in
tool_writeout.cthat falls backto
time()for targets without it.Ref: #22593
$ wine curl.exe -w '%time{%m/%d/%y}' https://curl.se/ --out-null