Conversation
There was a problem hiding this comment.
Pull request overview
Limits config-win32.h to legacy Visual Studio IDE projects.
Changes:
- Restricts configuration to MSVC 2010–2013.
- Removes MinGW-specific configuration.
- Simplifies Windows feature and type definitions.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AFAICT Itanium was last supported in VS2008. ARMs only worked for Windows CE, and ARM64 requires VS2017.
|
Just to add some datapoint, lest someone thinks "hey, let's remove this unused file.....who uses MSVC 2013 anway" I don't like this change: because I'm using config-win32.h with the latest Visual Studio 2026 (_MSC_VER = 1951) by maintaining my own "curl.vcxproj" file. Adding/removing the changed source files for every curl release is no big deal and is much less hustle than generating a .vcxproj using CMAKE and then changing all the improper VS settings to make it fit into my FreeFileSync solution. |
Why is it a hassle to run CMake configure after each curl release? |
|
Nothing against CMAKE, but it's not the tool for me. I find working inside Visual Studio a better fit for Windows development with highly-customized "vcxproj" files. The CMAKE generated project files are of no use . For Linux/macOS OTOH, "make" is fine and works great. |
For Windows and CMake there is also Ninja. If it fits or not depends on |
This is the only purpose it's maintained for.
Drop mingw-w64 and other logic falling outside of VS2010-2013 needs.
mingw-w64/MSVC platform differences keep being maintained/documented as
part of the CMake pre-fill logic in
CMake/win32-cache.cmake.Follow-up to ba8752e #12224