Conversation
There was a problem hiding this comment.
Pull request overview
Removes the obsolete handcrafted RISC OS configuration, standardizing RISC OS builds on autotools-generated configuration.
Changes:
- Deletes
config-riscos.h. - Removes its conditional inclusion and distribution entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/Makefile.am |
Stops distributing the obsolete header. |
lib/curl_setup.h |
Removes handcrafted RISC OS configuration loading. |
lib/config-riscos.h |
Deletes the legacy configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vszakats
marked this pull request as draft
August 15, 2026 15:41
vszakats
marked this pull request as ready for review
August 15, 2026 15:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the content of the latest downloadable builds available at
(from 2022): https://www.riscos.info/packages/src/Network/, these builds
used autotools, not the handcrafted header. Also the handcrafted header
did not see an update (that I could find) since
0866c1b (2002-04-08), other than
source-wide maintenance updates.
The newer, 8.0.1, download listed at https://curl.se/download.html#RISCOS
leads to a broken link. I assume it was also built with autotools.
https://www.riscos.info/packages/src/Network/curl_7.84.0-1_arm-src.zip: