Skip to content

config-riscos.h: delete handcrafted RISC OS config header, in favor of autotools - #22598

Closed
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:config-riscos
Closed

vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:config-riscos

Conversation

@vszakats

@vszakats vszakats commented Aug 15, 2026

Copy link
Copy Markdown
Member

According to the content of the latest downloadable builds available at
(from 2022): https://www.riscos.info/packages/src/Network/, these builds
used autotools, not the handcrafted header. Also the handcrafted header
did not see an update (that I could find) since
0866c1b (2002-04-08), other than
source-wide maintenance updates.


The newer, 8.0.1, download listed at https://curl.se/download.html#RISCOS
leads to a broken link. I assume it was also built with autotools.

https://www.riscos.info/packages/src/Network/curl_7.84.0-1_arm-src.zip:

It was created by curl configure -, which was
generated by GNU Autoconf 2.71.  Invocation command line was

  $ ./configure --host=arm-unknown-riscos --build=aarch64-unknown-linux-gnu --prefix=/data/gccsdk/env --x-libraries=/data/gccsdk/env/lib --x-includes=/data/gccsdk/env/include --enable-shared=no --enable-static=yes --with-openssl=/data/gccsdk/env --with-ssl --enable-ares --disable-ipv6 --without-brotli --without-gnutls --with-libssh2 --with-ca-bundle=InetDBase:CertData

@vszakats vszakats changed the title config-riscos.h: delete handcrafted config header config-riscos.h: delete handcrafted RISC OS config header, if favor of autotools Aug 15, 2026
@vszakats
vszakats requested a balanced review from Copilot August 15, 2026 15:37
@vszakats vszakats changed the title config-riscos.h: delete handcrafted RISC OS config header, if favor of autotools config-riscos.h: delete handcrafted RISC OS config header, in favor of autotools Aug 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the obsolete handcrafted RISC OS configuration, standardizing RISC OS builds on autotools-generated configuration.

Changes:

  • Deletes config-riscos.h.
  • Removes its conditional inclusion and distribution entry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
lib/Makefile.am Stops distributing the obsolete header.
lib/curl_setup.h Removes handcrafted RISC OS configuration loading.
lib/config-riscos.h Deletes the legacy configuration.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@vszakats
vszakats marked this pull request as draft August 15, 2026 15:41
@vszakats
vszakats marked this pull request as ready for review August 15, 2026 15:43
@vszakats vszakats closed this in 0c22fcf Aug 16, 2026
@vszakats
vszakats deleted the config-riscos branch August 16, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants