Conversation
bagder
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
bagder
marked this pull request as ready for review
August 17, 2026 11:02
- 'rtsp_transport' There is no need to keep this data around once the RTSP request has been issued. - 'accept_encoding' Only needed when creating the RTSP request. - 'uagent' The header is generated on demand from set.str[STRING_USERAGENT] - 'ref' Not necesary to keep around Closes #22603
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (2)
lib/rtsp.c:560
block.referreris allocated for every RTSP request with a configured referrer, but unlike the other request-local strings it is never freed on exit. This leaks the formatted header after both successful and failed requests.
curlx_free(block.accept_encoding);
lib/rtsp.c:509
- A custom RTSP
User-Agentno longer suppressesCURLOPT_USERAGENT.Curl_add_custom_headers()later appends the custom header, so requests containing both settings now send two User-Agent fields. Preserve the previous precedence by checkingCurl_checkheaders()before generating this header.
if(!result &&
data->set.str[STRING_USERAGENT] && *data->set.str[STRING_USERAGENT])
result = curlx_dyn_addf(&req_buffer,
"User-Agent: %s\r\n",
data->set.str[STRING_USERAGENT]);
bagder
force-pushed
the
bagder/urldata-rtsp_transport
branch
from
August 17, 2026 11:13
d2aaa70 to
ef3dd47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to keep this data around once the RTSP request has been issued.