Conversation
Especially important if reading cookies from HTTP headers, which is a style we discourage. Reported-by: accl on hackerone
There was a problem hiding this comment.
Pull request overview
Updates curl and libcurl documentation to better describe the pitfalls of loading cookies from HTTP header-style (Set-Cookie) files, and to steer users toward safer cookie file formats.
Changes:
- Rewords the
CURLOPT_COOKIEFILEdocumentation around domain matching for header-style cookie input. - Updates the
--cookiedocumentation to explicitly discourage the HTTP header-style format and to reword domain matching behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/libcurl/opts/CURLOPT_COOKIEFILE.md | Rewords guidance about importing cookies from header-style files and when such cookies get sent. |
| docs/cmdline-opts/cookie.md | Strengthens guidance discouraging header-style cookie files and rewords the domain-matching explanation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
words Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Especially important if reading cookies from HTTP headers, which is a style we discourage.
Reported-by: accl on hackerone