Conversation
Line should already have been removed in 7103a93, but neither humans nor clankers caught it. tststs...
There was a problem hiding this comment.
Pull request overview
This PR fixes connection reuse matching for NTLM authentication when the username is empty, aligning NTLM reuse behavior with the existing SSPI/empty-credentials handling logic in lib/url.c.
Changes:
- Remove the unconditional “empty user” rejection from NTLM connection reuse matching so reuse decisions flow through the existing SSPI empty-credentials guard.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
icing
changed the title
Member
|
I still disagree reuse of environment user connections is a security issue, if this has a hackerone report can you invite me I want to read it |
jay
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line should already have been removed in 7103a93, but neither humans nor clankers caught it. tststs...