Conversation
Do not mix HTTP auth options with custom Authorization headers.
There was a problem hiding this comment.
Pull request overview
This PR updates libcurl option documentation to warn that manually setting Authorization: / Proxy-Authorization: headers can conflict with libcurl’s built-in HTTP/proxy authentication options.
Changes:
- Add warning to
CURLOPT_HTTPAUTH(3)docs about conflicts with customAuthorization:headers. - Add warning to
CURLOPT_HTTPHEADER(3)docs about conflicts withCURLOPT_HTTPAUTH(3)/CURLOPT_PROXYAUTH(3). - Add warning to
CURLOPT_PROXYAUTH(3)docs about conflicts with customProxy-Authorization:headers (but with one incorrect cross-reference that needs fixing).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/libcurl/opts/CURLOPT_PROXYAUTH.md | Adds a warning about custom Proxy-Authorization: headers; contains a wrong reference to CURLOPT_HTTPAUTH(3) that should be CURLOPT_PROXYAUTH(3). |
| docs/libcurl/opts/CURLOPT_HTTPHEADER.md | Adds dedicated sections warning about Authorization: / Proxy-Authorization: header interactions with auth options. |
| docs/libcurl/opts/CURLOPT_HTTPAUTH.md | Adds a warning about conflicts when mixing CURLOPT_HTTPAUTH(3) with custom Authorization: headers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
oops Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not mix HTTP auth options with custom Authorization headers.