Conversation
Iterating unit test 1627 50,000 times show the new version to be ~27% faster on my machine. - unit1627: add more test strings, In particular three, five and six letter non-existing schemes. - remove scripts/schemetable.c, not used anymore
bagder
marked this pull request as ready for review
August 24, 2026 14:27
There was a problem hiding this comment.
Pull request overview
Optimizes scheme lookup by replacing the generated hash table with length-specific parsers and expanding unit coverage.
Changes:
- Adds specialized parsers for two- through seven-character schemes.
- Expands valid and invalid scheme test cases.
- Removes the obsolete scheme-table generator.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
lib/protocol.c |
Implements length-specific scheme lookup. |
tests/unit/unit1627.c |
Expands scheme tests and supports benchmarking iterations. |
tests/data/test1627 |
Updates expected invocation count. |
scripts/schemetable.c |
Removes the obsolete generator. |
scripts/Makefile.am |
Removes the generator from distribution files. |
.github/scripts/typos.toml |
Excludes generated-like test strings from typo checks. |
.github/scripts/codespell.sh |
Excludes generated-like test strings from codespell. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iterating unit test 1627 50,000 times show the new version to be ~31% faster on my machine.
unit1627: add more test strings, In particular three, five and six letter non-existing schemes.
remove scripts/schemetable.c, not used anymore