Conversation
Reported-by: Stanislav Fort
icing
approved these changes
Aug 25, 2026
There was a problem hiding this comment.
Pull request overview
Tightens OpenSSL TLS peer-certificate handling so that “no server certificate” is only treated as acceptable when certificate verification is disabled and no public-key pinning is configured, aligning behavior with the intent of pinned public key verification.
Changes:
- Refactors pinned-public-key option selection into a shared helper (
pinned()), including proxy vs non-proxy selection. - Updates the “no peer certificate” fast-path to also require that no pinned public key is configured before accepting the connection.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported-by: Stanislav Fort