Conversation
Reported-by: Stanislav Fort
bagder
marked this pull request as ready for review
August 25, 2026 09:21
Member
Author
|
Hm. They are somehow different context pointers... |
bagder
marked this pull request as draft
August 25, 2026 10:01
Member
Author
|
This needs a different take... |
bagder
changed the title
bagder
marked this pull request as ready for review
August 25, 2026 13:59
There was a problem hiding this comment.
Pull request overview
Prevents OpenSSL provider-backed TLS connections from being reused.
Changes:
- Marks provider-based connections for closure after use.
Suppressed comments (1)
lib/vtls/openssl.c:3762
connclose()only setsbits.close, which later HTTP/1.0Connection: keep-alivehandling clears viaconnkeep()(lib/http.c:3363,lib/connect.c:216-218). Such a provider-backed connection can therefore still be left reusable. Mark it permanently non-reusable as well so protocol keep-alive processing cannot undo this requirement.
connclose(data->conn);
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported-by: Stanislav Fort