Conversation
icing
approved these changes
Aug 25, 2026
This comment was marked as resolved.
This comment was marked as resolved.
And include it as key for connection reuse matching. Reported-by: Stanislav Fort Closes #22668
bagder
force-pushed
the
bagder/native-ca
branch
from
August 25, 2026 13:24
7b1e2d1 to
1de5c6d
Compare
There was a problem hiding this comment.
Pull request overview
This PR moves the native_ca_store flag from struct ssl_config_data into struct ssl_primary_config and updates TLS backends to read it from the connection’s primary SSL config, so it becomes part of the connection reuse/matching key.
Changes:
- Add
native_ca_storetostruct ssl_primary_configand remove it fromstruct ssl_config_data. - Update OpenSSL, wolfSSL, rustls, and GnuTLS backends to use
conn_config->native_ca_store(or equivalent primary config pointer). - Include
native_ca_storeinmatch_ssl_primary_config()to affect connection reuse matching.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/vtls/wolfssl.c | Switch native CA store decision to the connection primary config and update cache criteria accordingly. |
| lib/vtls/vtls_config.h | Move native_ca_store bit into struct ssl_primary_config. |
| lib/vtls/vtls_config.c | Add native_ca_store into primary-config matching and set it via SSL options/defaults. |
| lib/vtls/rustls.c | Use connection primary config for native CA store checks. |
| lib/vtls/openssl.c | Use connection primary config for native CA store behavior and cache criteria. |
| lib/vtls/gtls.c | Use primary config (struct ssl_primary_config) for native CA store decisions and cache criteria. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And include it as key for connection reuse matching.
Reported-by: Stanislav Fort