Skip to content

vtls: move 'native_ca_store' ssl_config_data => ssl_primary_config - #22668

Closed
bagder wants to merge 2 commits into
masterfrom
bagder/native-ca
Closed

bagder wants to merge 2 commits into
masterfrom
bagder/native-ca

Conversation

@bagder

@bagder bagder commented Aug 25, 2026

Copy link
Copy Markdown
Member

And include it as key for connection reuse matching.

Reported-by: Stanislav Fort

@bagder
bagder requested a review from icing August 25, 2026 11:48
@bagder bagder added the TLS label Aug 25, 2026
@testclutch

This comment was marked as resolved.

And include it as key for connection reuse matching.

Reported-by: Stanislav Fort

Closes #22668

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves the native_ca_store flag from struct ssl_config_data into struct ssl_primary_config and updates TLS backends to read it from the connection’s primary SSL config, so it becomes part of the connection reuse/matching key.

Changes:

  • Add native_ca_store to struct ssl_primary_config and remove it from struct ssl_config_data.
  • Update OpenSSL, wolfSSL, rustls, and GnuTLS backends to use conn_config->native_ca_store (or equivalent primary config pointer).
  • Include native_ca_store in match_ssl_primary_config() to affect connection reuse matching.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
lib/vtls/wolfssl.c Switch native CA store decision to the connection primary config and update cache criteria accordingly.
lib/vtls/vtls_config.h Move native_ca_store bit into struct ssl_primary_config.
lib/vtls/vtls_config.c Add native_ca_store into primary-config matching and set it via SSL options/defaults.
lib/vtls/rustls.c Use connection primary config for native CA store checks.
lib/vtls/openssl.c Use connection primary config for native CA store behavior and cache criteria.
lib/vtls/gtls.c Use primary config (struct ssl_primary_config) for native CA store decisions and cache criteria.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread lib/vtls/vtls_config.c
@bagder
bagder marked this pull request as ready for review August 25, 2026 14:59
@bagder bagder closed this in 7be1e70 Aug 25, 2026
@bagder
bagder deleted the bagder/native-ca branch August 25, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants