Conversation
The Makefile generated with autotools offers a 'tags' target that invokes etags to build a symbol database in 'TAGS'. For some reason it never indexes the symbols in the public include files and this is a somewhat crude way to make it to so. The downside with this take is that it repeats the header files names in the root Makefile. I still consider it valuable. The file set changes very rarely and this tags target is not critical.
There was a problem hiding this comment.
Pull request overview
Improves the autotools-generated tags/TAGS generation so etags also indexes curl’s public installed headers under include/curl/, addressing a gap where those symbols were previously missing from the TAGS database.
Changes:
- Add an explicit list of public
include/curl/*.hheaders to theetagsinvocation viaETAGS_ARGS. - Add
TAGS_DEPENDENCIESso TAGS rebuilds when those public headers change.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
okay Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Analysis of PR #22680 at 00d755ef: Test ../../tests/http/test_22_httpsrr.py::TestHTTPSRR::test_22_01_httpsrr_h1[DoH] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them). Generated by Testclutch |
bagder
marked this pull request as ready for review
August 26, 2026 10:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Makefile generated with autotools offers a 'tags' target that invokes etags to build a symbol database in 'TAGS'.
For some reason it never indexes the symbols in the public include files and this is a somewhat crude way to make it do so. The downside with this take is that it repeats the header files names in the root Makefile. I still consider it valuable. The file set changes very rarely and this tags target is not critical.