Conversation
Verified by test 321 Reported-by: Stanislav Fort
There was a problem hiding this comment.
Pull request overview
This PR fixes --etag-save - behavior when stdout is redirected (e.g., >> file) by preventing curl’s ETag-saving code from truncating the underlying stdout file descriptor, and adds a regression test to cover the scenario.
Changes:
- Only truncate the ETag output target when it is a curl-managed regular file (not stdout) in
save_etag(). - Add a new test (321) validating that
--etag-save -redirected with>>appends without truncating existing content. - Register the new test in the test data makefile.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/data/test321 | New regression test for --etag-save - with stdout redirection + append. |
| tests/data/Makefile.am | Adds test321 to the test list. |
| src/tool_cb_hdr.c | Gates ETag-file truncation on OutStruct::regular_file to avoid truncating stdout. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fix Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified by test 321
Reported-by: Stanislav Fort