schannel: refresh stream sizes after renegotiation - #22692
Closed
martin-fzi wants to merge 3 commits into
Closed
martin-fzi wants to merge 3 commits into
martin-fzi wants to merge 3 commits into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Pull request overview
Refreshes cached Schannel record sizes after TLS renegotiation.
Changes:
- Clears cached stream-size attributes when renegotiation finishes.
- Forces the next send to query the updated security context.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jay
reviewed
Aug 26, 2026
added 2 commits
August 27, 2026 10:20
Re-query SECPKG_ATTR_STREAM_SIZES after successful renegotiation instead of relying on schannel_send() to refresh the cached values later. Suggested-by: Jay Satiro
Move the SECPKG_ATTR_STREAM_SIZES query to schannel_connect() completion, where it runs after both initial negotiation and renegotiation. This avoids relying on schannel_send() to refresh the cached values later. Suggested-by: Jay Satiro
jay
approved these changes
Aug 27, 2026
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset cached Schannel stream sizes after renegotiation, since the renegotiated security context may use different record sizes. This forces the next send to re-query
SECPKG_ATTR_STREAM_SIZES.