Conversation
In disable-verbose builds Pointed out by Codex Security
There was a problem hiding this comment.
Pull request overview
Fixes a potential NULL dereference in the ngtcp2 HTTP/3 send path when building with CURL_DISABLE_VERBOSE_STRINGS (disable-verbose builds), where VERBOSE(...) compiles to a no-op and previously skipped an essential stream-context assignment.
Changes:
- Remove
VERBOSE(...)wrapping fromstream = H3_STREAM_CTX(ctx, data);so the assignment always executes after successfully opening a stream.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bagder
marked this pull request as ready for review
August 27, 2026 06:11
icing
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In disable-verbose builds
Pointed out by Codex Security