Conversation
For entries with a leading tab. Verified in test 2885. Reported-by: Stanislav Fort
There was a problem hiding this comment.
Pull request overview
Improves cookie parsing so tab-prefixed attributes such as Secure are recognized.
Changes:
- Allows tabs within parsed cookie segments before trimming whitespace.
- Adds HTTPS regression coverage for tab-prefixed
Secure. - Registers test 2885.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/cookie.c |
Corrects tab handling in cookie parsing. |
tests/data/test2885 |
Tests tab-prefixed cookie attributes. |
tests/data/Makefile.am |
Registers the new test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Analysis of PR #22699 at d9f44109: Test 2885 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 72 different CI jobs (the link just goes to one of them). Generated by Testclutch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For entries with a leading tab. Verified in test 2885.
Reported-by: Stanislav Fort