Conversation
Reported-by: Stanislav Fort Verified by test 2397
There was a problem hiding this comment.
Pull request overview
Allows CURLOPT_REFERER to safely reuse a pointer returned by CURLINFO_REFERER.
Changes:
- Delays freeing the existing referer until after copying the new value.
- Adds regression test 2397 and registers it.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
lib/setopt.c |
Safely replaces the referer value. |
tests/libtest/lib2397.c |
Exercises referer pointer reuse. |
tests/data/test2397 |
Defines redirect test behavior. |
tests/libtest/Makefile.inc |
Registers the test source. |
tests/data/Makefile.am |
Registers test 2397. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
language Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported-by: Stanislav Fort
Verified by test 2397