Conversation
Floating point is odd but it features this concept of "infinite" (which can happen with the new typecast from long double to double) and apparently dividing infinite with 10 is still infinte. Follow-up to bdda3a2 Pointed out by: Codex Security
There was a problem hiding this comment.
Pull request overview
This PR fixes a potential never-ending loop in lib/mprintf.c when formatting positive infinity as a floating-point number. It does so by ensuring the digit-reduction loop is bounded by the remaining precision budget (maxprec), preventing infinite values from causing non-terminating behavior.
Changes:
- Bound the
while(val >= 10.0)loop withmaxprecto guarantee termination even whenvalis+inf.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Floating point is odd but it features this concept of "infinite" (which can happen with the new typecast from long double to double) and apparently dividing infinite with 10 is still infinte.
Follow-up to bdda3a2
Pointed out by: Codex Security