Conversation
When a HTTP/2 push requires a new easy handle, create a clean easy and do *not* duplicate the existing one. This avoids messy use of the API `curl_easy_duphandle()`, which has some caveats the applictions must observe and cannot do so for a h2 push. Using a clean easy handle is also better since the pushed stream has no real relation to the easy handle that was in use when the HTTP/2 push arrived (it could be any easy using the connection). Inheriting settings/inputs from a somewhat "random" existing easy seems wrong.
bagder
approved these changes
Aug 28, 2026
Member
|
Also related: #22490 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a HTTP/2 push requires a new easy handle, create a clean easy and do not duplicate the existing one. This avoids messy use of the API
curl_easy_duphandle(), which has some caveats the applictions must observe and cannot do so for a h2 push.Using a clean easy handle is also better since the pushed stream has no real relation to the easy handle that was in use when the HTTP/2 push arrived (it could be any easy using the connection).
Inheriting settings/inputs from a somewhat "random" existing easy seems wrong.