Conversation
When not explicitly set, give the connection a present scope_id from the first peer of a connection, not from its origin. This accounts for proxies.
bagder
approved these changes
Aug 28, 2026
There was a problem hiding this comment.
Pull request overview
Updates how conn->scope_id is chosen for IPv6 connections when the user has not explicitly set CURLOPT_SCOPE_ID, intending to use the first hop/peer’s scope rather than the request origin (to better handle proxy scenarios).
Changes:
- Replace the default
conn->scope_idsource fromdata->state.origin->scopeidtoCurl_conn_get_first_peer(...)->scopeidwhen no explicit scope_id is set. - Add a guard that errors out if the “first peer” cannot be obtained.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bagder
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When not explicitly set, give the connection a present scope_id from the first peer of a connection, not from its origin. This accounts for proxies.