mprintf: acknowledge %F - #22719
Closed
bagder wants to merge 1 commit into
Closed
mprintf: acknowledge %F#22719bagder wants to merge 1 commit into
bagder wants to merge 1 commit into
Conversation
The code previously just ignored it, causing variadic argument desynchronization Extend test 557 to verify Reported-by: Stanislav Fort
There was a problem hiding this comment.
Pull request overview
Adds %F support to mprintf, preventing variadic argument desynchronization.
Changes:
- Parses
%Fas an uppercase floating-point conversion. - Adds regression coverage in test 557.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/mprintf.c |
Handles and emits %F. |
tests/libtest/lib557.c |
Verifies %F formatting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code previously just ignored it, causing variadic argument desynchronization
Extend test 557 to verify
Reported-by: Stanislav Fort